-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Figma code connect components #4320
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4a984a1
to
932e778
Compare
1211fe9
to
e3496f0
Compare
9c5cf7d
to
23c4495
Compare
This PR shows the diff of what's been tried with Figma code connect for Salt (Next) Figma library, in case anyone case want to update on any new library.
Figma code connect docs -
https://github.com/figma/code-connect/blob/main/docs/react.md
Below components are published to Salt (Next) Figma library, keeping as a branch until this can be formalized as a requirement to be maintained
Learnings
Most of text / label in our Figma components is controlled via 2 props (one boolean & one string), therefore code connect will generate 2 separate prop mapping (one
figma.boolean
&figma.string
). The correct way to map them is usingvalueMapping
object, e.g. below. See more on Figma doc.Scripts
For icons update from - https://github.com/figma/code-connect/blob/main/cli/scripts/import-icons.ts